New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvements for greater flexibility #70

Open

seirios wants to merge 3 commits into raivokolde:master from seirios:master

seirios commented Jun 10, 2020

This PR contains three improvements which I've found useful when using pheatmap.

Honor number_format when using a matrix in display_numbers. This is technically a bugfix(?)
Allow number_color to be a function, which allows setting text color based on background color. This is useful for getting good contrast against colormaps.
Honor gaps_row/col settings when clustering rows/columns if cutree_rows/cols is unset. This allows for greater customization and doesn't hurt, right?

Cheers!

SBP added 3 commits

June 10, 2020 20:50


          Honor number_format if display_numbers is a matrix

e7d6037


          Allow number_color to be a function

5d12c7b


          Honor gaps_row/col when clustering if cutree_rows/cols unset

3f2a250

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet