Fixed the way event listeners are removed #731
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Thank you @Yama-Tomo for this PR ! I am working on migrating the class components to function components, any chance you can rebase this on top of |
|
@rakannimer Rebased code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
relate: #716
Fixed a problem in strict mode where removing an event listener using removeAllListeners would remove all added event listeners.
Also fixed a problem where event listeners would not be re-registered when a new callback was passed due to re-rendering. 1
Footnotes
fix: fix problem loading events in tables when displayed for the firs… #709 Probably, this changes prevented listeners from re-registering when the props was changed. ↩