Fix shellcheck issues

rake5k · Sep 22, 2023 · 3e4ee8a · 3e4ee8a
1 parent d19e226
commit 3e4ee8a
Showing 1 changed file with 9 additions and 3 deletions.
diff --git a/lib/apps/nixos-install.sh b/lib/apps/nixos-install.sh
@@ -33,7 +33,9 @@ is_nvme_disk() {
 }
 
 get_partition() {
-    if is_nvme_disk; then
+    is_nvme="$(is_nvme_disk)"
+    local is_nvme
+    if "${is_nvme}"; then
         echo "${DISK}p${1}"
     else
         echo "${DISK}${1}"
@@ -141,7 +143,9 @@ install() {
 
 ### Pull the trigger
 
-if _read_boolean "Do you want to DELETE ALL PARTITIONS?" N; then
+DO_PARTITION="$(_read_boolean "Do you want to DELETE ALL PARTITIONS?" N)"
+readonly DO_PARTITION
+if "${DO_PARTITION}"; then
     partition
     create_volumes
     create_filesystems
@@ -155,7 +159,9 @@ if [[ ${LVM_PV_NUM_ACTIVE} -lt 1 ]]; then
     decrypt_lvm
 fi
 
-if _read_boolean "Do you want to INSTALL NixOS now?" N; then
+DO_INSTALL="$(_read_boolean "Do you want to INSTALL NixOS now?" N)"
+readonly DO_INSTALL
+if "${DO_INSTALL}"; then
     install
 fi