Skip to content

Commit

Permalink
added -p to mkdir as previous fix didn't work
Browse files Browse the repository at this point in the history
  • Loading branch information
@dalekopera
dalekopera committed Aug 13, 2024
1 parent b2456e7 commit 70b2ad9
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions bin/install_sifdecode_main
View file
Original file line number Diff line number Diff line change
Expand Up @@ -35,11 +35,11 @@ MODDIR=$SIFDECODE/modules/$VERSION
echo "$MACHINE ($OPSYS) $COMPUSED" > $SIFDECODE/versions/$VERSION

if [[ ! -e $OBJDIR ]]; then
$MKDIR $OBJDIR
$MKDIR -p $OBJDIR
fi

if [[ ! -e $MODDIR ]]; then
$MKDIR $MODDIR
$MKDIR -p $MODDIR
fi

# write out the sifdecode/bin/sys file for this architecture
Expand Down

5 comments on commit 70b2ad9

@amontoison
Copy link
Member

@amontoison amontoison commented on 70b2ad9 Aug 13, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nimgould We rely on the script of ArchDefs in CI for SIFDecode and CUTEst:
https://github.com/ralna/SIFDecode/blob/master/.github/workflows/ci.yml#L64

The local bin/install_sifdecode_main is never used.

@nimgould
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I commited this change, and it made no difference. What is going on?

I'm away doing other things from 17:00, more later in the week

@nimgould
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The file is in sifdecode. But I don't understand why it is trying to use
/home/runner/work/SIFDecode/SIFDecode/objects/pc64.lnx.gfo
why is there a second SIFDecode here?

@amontoison
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's this one Nick that should be modified:
https://github.com/ralna/ARCHDefs/blob/master/bin/install_optrove

@nimgould
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no mkdir in this file, it relies on the script from sifdecode/bin, which is the one I altered. Looks like we need to put in a -vx to get verbose output

Please sign in to comment.