Per-app Language Preferences 1.1 #1458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m417z
reviewed
Jan 23, 2025
| break; | ||
| } | ||
| if(S_OK == PathMatchSpecExW(filename_buf, glob, PMSF_MULTIPLE)) { | ||
| lang_id = Wh_GetIntSetting(L"programList[%d].langId", index); |
There was a problem hiding this comment.
The string is not freed with Wh_FreeStringSetting in this case. Note that you can also use WindhawkUtils::StringSetting to have it freed automatically.
It seems to be correct from a quick glance. An alternative approach you could use it determining the language in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
GetUserDefaultUILanguageis actually called very often in some apps such asexplorer.exe. As I have observed, allocating the image path buffer and determining the language for each call can add much overhead. Now I choose to determine the language ID only once for each process at startup, and then return the pre-determined language ID for subsequent calls.This approach seems to work fine, but may not be entirely correct. Please let me know if there is some better way of implementing this.