Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Win32 Tray Clock Experience 1.0.0 #446

Merged
merged 3 commits into from
Dec 25, 2023
Merged

Win32 Tray Clock Experience 1.0.0 #446

merged 3 commits into from
Dec 25, 2023

Conversation

aubymori
Copy link
Contributor

This mod makes the clock button on the Windows 10 taskbar open the Win32 tray clock from Windows 8.1 and before instead of the XAML one from Windows 10 and up. This should work on Windows 11 with the legacy taskbar, but I have not tested it.

Preview:
Preview

@aubymori
Copy link
Contributor Author

@m417z Should be good now. Tell me if there's any issues, this was all written and committed from my phone, lol.

@m417z
Copy link
Member

m417z commented Dec 25, 2023

Impressive 🙂 but:

mod.wh.cpp:155:9: error: use of undeclared identifier 'STATUS_SUCCESS'
    if (STATUS_SUCCESS == RtlGetVersion(&osv))
        ^
1 error generated.

I'd also check the major version, one day MS might want to make it 11 or 12, who knows...

@aubymori
Copy link
Contributor Author

Impressive 🙂 but:

mod.wh.cpp:155:9: error: use of undeclared identifier 'STATUS_SUCCESS'
    if (STATUS_SUCCESS == RtlGetVersion(&osv))
        ^
1 error generated.

The fact that NTSTATUS is defined but not STATUS_SUCCESS is really something...

I'd also check the major version, one day MS might want to make it 11 or 12, who knows...

They didn't change it with 11 and it's not like they're going to bump the build number back to below 22000, so I don't see any problem with my checking.

@m417z
Copy link
Member

m417z commented Dec 25, 2023

I agree that it's mainly esthetics in this case, it just makes me think about stories like this: https://devblogs.microsoft.com/oldnewthing/20040213-00/?p=40633

In any case, it compiles now, merging...

@m417z m417z merged commit a365603 into ramensoftware:main Dec 25, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants