Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update zh-CN.yml #45

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Update zh-CN.yml #45

wants to merge 2 commits into from
+95 −95

Conversation

ericcartmanfatass
Copy link

i've updated the simplified chinese translation, plz check~

m417z
m417z reviewed Jan 9, 2025
View reviewed changes
Copy link
Member

@m417z m417z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution.

zh-CN.yml Outdated
contribute: "<0>协助我们贡献您的翻译</0>."
credits: "简体中文翻译由<0>Shifeng Zhao</0>提供。"
creditsLink: "mailto:[email protected]"
creditsLink: "https://19950602.xyz/"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was this changed?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i am shifeng and in the previous ver, i dont know how to pr and didnt have my own website. If u guys think its not okay, u could keep the previous one😂

@m417z
Copy link
Member

m417z commented Jan 9, 2025

@MZhao-ouo can you please review the changes?

@MZhao-ouo
Copy link
Contributor

Hi @m417z,
Thank you for your mention.

Hi @ericcartmanfatass, thanks for your contribution. Great work overall, but some changes were unnecessary:

  • "Mod" is understandable and doesn't need to be changed to "模块."
  • Please ensure menu shortcuts follow the structure like (&O).

@ericcartmanfatass
Copy link
Author

Hi @m417z,
After the review of @MZhao-ouo, I have update the translation which he mentioned in the comment and due to lack of explainations and some misunderstanding I delete the contact information and revert it. Sorry for the inconvience for you guys.

Hi @MZhao-ouo,
Thx for the review of the translation, I update a newer one, could you plz check it if you have some spare time, thx.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m417z m417z m417z left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ericcartmanfatass @m417z @MZhao-ouo