This repository has been archived by the owner on Feb 12, 2022. It is now read-only.
Allow parsing RAML files with model extensions #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The validator already detects invalid keys, so the parser doesn't need to report them by throwing an exception. This allows to read the valid parts from an invalid RAML file.
Add constructor so that the RamlDocumentBuilder can also parse custom sub-classes of Raml. In this way, the RAML model can be extended.
Use a LinkedHashMap to ensure that fields from model sub-classes are preferred over fields from base classes.
|
@svacas What does this mean that this pull request is "closed"? My changes haven't been merged yet. |
|
it was a mistake when switching the master branch |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The RAML parser project actually also includes a pretty cool model-based YAML parser. With that parser, it is pretty easy to create own models and call the
YamlDocumentBuilderto parse them.Now I don't want to use arbitrary models, but I want to parse a RAML model with a few extensions. So it would be nice if I could call the
RamlDocumentBuilderand have it parse a model class which is a sub-class ofRaml.This is actually pretty easy to implement - it only requires changes in a few lines of code.
This pull request extends pull request #87