update docker rke2 template for fleet #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Carlos Salas <[email protected]>
salasberryfin
requested review from
a team and
dharmit
and removed request for
dharmit
dharmit
reviewed
Feb 11, 2025
| @@ -41,7 +45,7 @@ metadata: | |||
| spec: | |||
| template: | |||
| spec: | |||
| customImage: kindest/node:v1.26.0 | |||
| customImage: kindest/node:v1.31.0 | |||
There was a problem hiding this comment.
We recommend 1.30.0 here: https://github.com/rancher/turtles/blob/8a1d7e68999a1cfc7888ac2cf4d802a85ca1a3f9/scripts/kind-cluster-with-extramounts.yaml.
In CAPRKE2 docs, we don't recommend any version, so it pulls 1.32.0 as that's presently the latest: https://github.com/rancher/cluster-api-provider-rke2/blob/c00d2a44600e43f0bef2dd85daabf04da607b213/docs/book/src/04_developer/01_development.md
And now here 1.31.0 across this file.
My point being, should we have a uniform k8s version being used across the places? From dev perspective, it's probably not important, but it is from users/customers POV, IMO.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update Docker RKE2 template based on recent changes. This aligns the template with what's used in Turtles E2E. Additionally, this updates K8s version.