feat: move Image to storage and implement field selectors #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabriziosestito
force-pushed
the
fix/worker-create-catalog
branch
from
50dc09d to
6aed2a9
Compare
fabriziosestito
changed the title
fabriziosestito
force-pushed
the
fix/worker-create-catalog
branch
from
6aed2a9 to
5d0c560
Compare
fabriziosestito
commented
Nov 11, 2024
| @@ -15,7 +15,7 @@ spec: | |||
| labels: | |||
| worker: "true" | |||
| spec: | |||
| serviceAccountName: apiserver | |||
| serviceAccountName: controller-manager | |||
There was a problem hiding this comment.
@flavio we need to change this when we work on the helm chart
There was a problem hiding this comment.
Can you add a TODO for that or create an issue to keep track of it?
fabriziosestito
force-pushed
the
fix/worker-create-catalog
branch
from
5d0c560 to
3b1b471
Compare
flavio
approved these changes
Nov 11, 2024
| @@ -15,7 +15,7 @@ spec: | |||
| labels: | |||
| worker: "true" | |||
| spec: | |||
| serviceAccountName: apiserver | |||
| serviceAccountName: controller-manager | |||
There was a problem hiding this comment.
Can you add a TODO for that or create an issue to keep track of it?
Signed-off-by: Fabrizio Sestito <[email protected]>
Signed-off-by: Fabrizio Sestito <[email protected]>
Signed-off-by: Fabrizio Sestito <[email protected]>
Signed-off-by: Fabrizio Sestito <[email protected]>
Signed-off-by: Fabrizio Sestito <[email protected]>
Signed-off-by: Fabrizio Sestito <[email protected]>
Signed-off-by: Fabrizio Sestito <[email protected]>
Signed-off-by: Fabrizio Sestito <[email protected]>
Signed-off-by: Fabrizio Sestito <[email protected]>
Signed-off-by: Fabrizio Sestito <[email protected]>
fabriziosestito
force-pushed
the
fix/worker-create-catalog
branch
from
3b1b471 to
9b26244
Compare
Signed-off-by: Fabrizio Sestito <[email protected]>
Signed-off-by: Fabrizio Sestito <[email protected]>
Signed-off-by: Fabrizio Sestito <[email protected]>
Signed-off-by: Fabrizio Sestito <[email protected]>
fabriziosestito
force-pushed
the
fix/worker-create-catalog
branch
from
9b26244 to
0404e4f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the
Imagetype from the controller to storage and implements image metadata field selectors, removing the labels.It also implements an
Imagestore.