Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update sriov chart to 103.0.0 #3039

Merged
merged 3 commits into from
Sep 26, 2023
Merged

Update sriov chart to 103.0.0 #3039

merged 3 commits into from
Sep 26, 2023

Conversation

mgfritch
Copy link
Contributor

@mgfritch mgfritch commented Sep 25, 2023 •
edited
Loading

Issue:

Also updates chart to use node-feature-discovery v0.14.1

Resolves:
rancher/rke2#4654
rancher/rke2#4489
rancher/rke2#4499

Problem

  • Update SRIOV charts to dev-v2.8
  • Provide support for multi-arch SRIOV images
  • kube-version > v1.28 requires an updated node-feature-discovery > v0.13.4

Solution

Testing

Engineering Testing

Manual Testing

Deploy charts via helm using a three node RKE2 v1.28.2+rke2r1 cluster

Automated Testing

QA Testing Considerations

Regressions Considerations

Backporting considerations

@mgfritch mgfritch force-pushed the sriov-103-dev-2.8 branch 2 times, most recently from ab4e25d to bfc09a1 Compare September 26, 2023 16:53
@github-actions
Copy link

github-actions bot commented Sep 26, 2023 •
edited by rohitsakala
Loading

Validation steps

  • Ensure all container images have repository and tag on the same level to ensure that all container images are included in rancher-images.txt which are used by airgap customers.

Ex:-
longhorn-controller:
repository: rancher/hardened-sriov-cni
tag: v2.6.3-build20230913

@mgfritch
Update sriov version to 103.0.0
799c9f4 
follow-up to bcab8844d807ee1db558533248273ccd492874bb

Signed-off-by: Michael Fritch <[email protected]>
@mgfritch
Update nfd to v0.14.1
544f8ff 
Signed-off-by: Michael Fritch <[email protected]>
@mgfritch
make charts
32c9fb2 
Signed-off-by: Michael Fritch <[email protected]>
@github-actions
Copy link

github-actions bot commented Sep 26, 2023 •
edited by rohitsakala
Loading

Validation steps

  • Ensure any new images have repository and tag on the same level to ensure the rancher-images.txt is generated correctly for it for airgap scenarios.

@rohitsakala rohitsakala merged commit e38f7be into rancher:dev-v2.8 Sep 26, 2023
9 of 10 checks passed
@mgfritch mgfritch deleted the sriov-103-dev-2.8 branch September 26, 2023 23:29
@mgfritch mgfritch mentioned this pull request Sep 27, 2023
Merged
@lucasmlp lucasmlp mentioned this pull request Nov 1, 2023
Merged
4 tasks
@snasovich snasovich mentioned this pull request Feb 6, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manuelbuil manuelbuil manuelbuil approved these changes

@rohitsakala rohitsakala rohitsakala approved these changes

@brandond brandond brandond approved these changes

@thomasferrandiz thomasferrandiz Awaiting requested review from thomasferrandiz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mgfritch @brandond @rohitsakala @manuelbuil