-
Notifications
You must be signed in to change notification settings - Fork 716
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[dev-v2.9] Update sriov chart to 104.0.0 #3841
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update to the latest sriov chart and images: - suse-edge/charts#104 - suse-edge/charts#108 Issue: rancher/rke2#5089 Signed-off-by: Michael Fritch <[email protected]>
suse-edge/charts#107 Signed-off-by: Michael Fritch <[email protected]>
suse-edge/charts#110 Signed-off-by: Michael Fritch <[email protected]>
Signed-off-by: Michael Fritch <[email protected]>
Validation steps
Ex:- longhorn-controller: repository: rancher/hardened-sriov-cni tag: v2.6.3-build20230913
|
thomasferrandiz
approved these changes
May 2, 2024
manuelbuil
approved these changes
May 2, 2024
lucasmlp
approved these changes
May 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
Also, thanks for breaking the changes into smaller commits 🙂
krunalhinguu
pushed a commit
to krunalhinguu/charts
that referenced
this pull request
May 14, 2024
Signed-off-by: Michael Fritch <[email protected]>
krunalhinguu
pushed a commit
to krunalhinguu/charts
that referenced
this pull request
Jul 15, 2024
Signed-off-by: Michael Fritch <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: rancher/rke2#5089
Problem
Update to the latest sriov chart and images:
Add supported nic for the use case pw:
Provide a way to add extra supported NICs:
Testing
Deploy charts via helm using a two node RKE2 v1.29.4+rke2r1 cluster.