Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dev-v2.9] Update sriov chart to 104.0.0 #3841

Merged
merged 4 commits into from
May 3, 2024

Conversation

mgfritch
Copy link
Contributor

@mgfritch mgfritch commented May 1, 2024

Issue: rancher/rke2#5089

Problem

Update to the latest sriov chart and images:

Add supported nic for the use case pw:

Provide a way to add extra supported NICs:

Testing

Deploy charts via helm using a two node RKE2 v1.29.4+rke2r1 cluster.

Update to the latest sriov chart and images:
- suse-edge/charts#104
- suse-edge/charts#108

Issue: rancher/rke2#5089
Signed-off-by: Michael Fritch <[email protected]>
Signed-off-by: Michael Fritch <[email protected]>
@mgfritch mgfritch requested review from a team as code owners May 1, 2024 00:04
@mgfritch mgfritch requested a review from manuelbuil May 1, 2024 00:04
Copy link

github-actions bot commented May 1, 2024

Validation steps

  • Ensure all container images have repository and tag on the same level to ensure that all container images are included in rancher-images.txt which are used by airgap customers.
  Ex:-
    longhorn-controller:
      repository: rancher/hardened-sriov-cni
      tag: v2.6.3-build20230913
  
  • Add a 👍 (thumbs up) reaction to this comment once done. CI won't pass without this reaction to the github-action bot's latest validation comment.
  • Approve the PR to run the CI check.

Copy link
Contributor

@lucasmlp lucasmlp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Also, thanks for breaking the changes into smaller commits 🙂

@mgfritch mgfritch merged commit 2a4423a into rancher:dev-v2.9 May 3, 2024
8 checks passed
@mgfritch mgfritch deleted the sriov-104 branch May 3, 2024 00:40
krunalhinguu pushed a commit to krunalhinguu/charts that referenced this pull request May 14, 2024
krunalhinguu pushed a commit to krunalhinguu/charts that referenced this pull request Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants