[WIP] [dev-v2.10] rancher-logging 105.2.0-rc.1+up4.10.0 create #4907
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Validation steps
Ex:-
longhorn-controller:
repository: rancher/hardened-sriov-cni
tag: v2.6.3-build20230913
|
jbiers
force-pushed
the
expose-logging-values
branch
from
837dbe9 to
839d509
Compare
Validation steps
Ex:-
longhorn-controller:
repository: rancher/hardened-sriov-cni
tag: v2.6.3-build20230913
|
jbiers
force-pushed
the
expose-logging-values
branch
from
839d509 to
0b7c725
Compare
Validation steps
Ex:-
longhorn-controller:
repository: rancher/hardened-sriov-cni
tag: v2.6.3-build20230913
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: rancher/rancher#48364
Problem
This PR is a fix for the internal issue SURE-9146 which requests the possibility of setting a different number of replicas and resources for the fluentd Statefulset of each logging, as well as different resources and loggingRef for their fluentbitagent.
This is currently not possible on a per-logging basis, a user can only update these values for all loggings at once using values.loggingOverlay or values.fluentbit+values.fluentd.
Solution
My current solution is simply to make these values configurable for each logging via the additionalLoggingSource.logging-name.fluentd and additionalLoggingSource.logging-name.fluentbit fields. It seems to me like this has been done to some capacity in the past for fields like additionalLoggingSource.kubeAudit.fluentbit, so my choice was to continue with this mechanism of exposing values.
Other solutions are viable, for instance using a mechanism similar to what is done in the loggingServiceAccountAnnotations field. However I chose to continue with the idea that was already implemented in the past.
Backporting considerations
Backport to 2.9 and forwardport to 2.11