Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[dev-v2.9] prometheus-federator 104.1.0-rc.1+up0.4.5 remove / 104.1.0+up0.4.5 create #4934

Merged
merged 3 commits into from
Jan 10, 2025
Merged

[dev-v2.9] prometheus-federator 104.1.0-rc.1+up0.4.5 remove / 104.1.0+up0.4.5 create #4934

merged 3 commits into from
Jan 10, 2025

Conversation

mallardduck
Copy link
Member

Blocked by QA validation of: rancher/rancher#48567

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 8, 2025

Validation steps

  • Ensure all container images have repository and tag on the same level to ensure that all container images are included in rancher-images.txt which are used by airgap customers.
  Ex:-
    longhorn-controller:
      repository: rancher/hardened-sriov-cni
      tag: v2.6.3-build20230913
  • Add a 👍 (thumbs up) reaction to this comment once done. CI won't pass without this reaction to the github-action bot's latest validation comment.
  • Approve the PR to run the CI check.

@mallardduck mallardduck changed the title CHART=prometheus-federator VERSION=104.1.0-rc.1+up0.4.5 make remove [dev-v2.9] prometheus-federator 104.1.0-rc.1+up0.4.5 remove / 104.1.0+up0.4.5 create Jan 8, 2025
@mallardduck mallardduck marked this pull request as ready for review January 10, 2025 18:48
@mallardduck mallardduck requested a review from a team as a code owner January 10, 2025 18:48
@github-actions GitHub Actions
Copy link

Validation steps

  • Ensure all container images have repository and tag on the same level to ensure that all container images are included in rancher-images.txt which are used by airgap customers.
  Ex:-
    longhorn-controller:
      repository: rancher/hardened-sriov-cni
      tag: v2.6.3-build20230913
  • Add a 👍 (thumbs up) reaction to this comment once done. CI won't pass without this reaction to the github-action bot's latest validation comment.
  • Approve the PR to run the CI check.

@mallardduck mallardduck requested a review from jbiers January 10, 2025 18:48
@mallardduck mallardduck merged commit ce33752 into rancher:dev-v2.9 Jan 10, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbiers jbiers jbiers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mallardduck @jbiers