-
Notifications
You must be signed in to change notification settings - Fork 718
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[dev-v2.11] rancher-monitoring 106.0.0+up61.3.2 update #5106
Open
alexandreLamarre
wants to merge
3
commits into
rancher:dev-v2.11
Choose a base branch
from
alexandreLamarre:bump-rancher-monitoring-annotation
base: dev-v2.11
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[dev-v2.11] rancher-monitoring 106.0.0+up61.3.2 update #5106
alexandreLamarre
wants to merge
3
commits into
rancher:dev-v2.11
from
alexandreLamarre:bump-rancher-monitoring-annotation
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Validation steps
Ex:- longhorn-controller: repository: rancher/hardened-sriov-cni tag: v2.6.3-build20230913
|
cef308f
to
96437de
Compare
Validation steps
Ex:- longhorn-controller: repository: rancher/hardened-sriov-cni tag: v2.6.3-build20230913
|
Signed-off-by: Alexandre Lamarre <[email protected]>
Signed-off-by: Alexandre Lamarre <[email protected]>
Signed-off-by: Alexandre Lamarre <[email protected]>
96437de
to
5ffa6cf
Compare
Validation steps
Ex:- longhorn-controller: repository: rancher/hardened-sriov-cni tag: v2.6.3-build20230913
|
@@ -14,7 +14,7 @@ annotations: | |||
catalog.cattle.io/namespace: cattle-monitoring-system | |||
catalog.cattle.io/permits-os: linux,windows | |||
catalog.cattle.io/provides-gvr: monitoring.coreos.com.prometheus/v1 | |||
catalog.cattle.io/rancher-version: '>= 2.10.0-0 < 2.11.0-0' | |||
catalog.cattle.io/rancher-version: '>= 2.11.0-0 < 2.12.0-0' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @alexandreLamarre per the review on #5064 I have incorporated the rancher version bumps too in the same commit.
Would it be feasible to eliminate this rancher version bump changes from here, and continue with merging of #5064?
cc @jbiers @mallardduck
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
rancher/rancher#48089
#5074 accidentally did not fix the issue, so introducing the fix here
Problem
Solution
Testing
Engineering Testing
Manual Testing
Automated Testing
QA Testing Considerations
Regressions Considerations