Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to deploy AWS external tree provider in RKE2 #9110

Closed
nwmac opened this issue Jun 13, 2023 · 5 comments · Fixed by #9643 or #9914
Closed

Ability to deploy AWS external tree provider in RKE2 #9110

nwmac opened this issue Jun 13, 2023 · 5 comments · Fixed by #9643 or #9914

Comments

@nwmac
Copy link
Member

nwmac commented Jun 13, 2023

Internal Ref: SURE-4760

The external AWS cloud provider (CCM) deploys onto a cluster and relies on the hostname and/or --provider-id flag (kubelet) to describe the node and initialise into the cluster.

With v2-provisioning, the hostname is always set to a node pool naming convention (OS (see userdata example below) & with -hostname-override), and there appears to be no way of providing the values dynamically to the -provider-id flag.

@gaktive
Copy link
Member

gaktive commented Jul 14, 2023

Need guidance from PM and @Sahota1225 about what UI requirements are here.

This should be done in tandem with #9204

@gaktive
Copy link
Member

gaktive commented Aug 9, 2023

Need to sync with backend to ensure we're on the same page here.

No E2E since this is AWS so this will be manually tested.

@slickwarren
Copy link
Contributor

slickwarren commented Oct 11, 2023

tested on v2.8-head (6376016)
currently, there is no notification to the user on rke2 that there is a requirement for additional settings when using aws cloud provider option. Can we add a banner or something similar that links to the rancher documentation for using out-of-tree when 1.27.x + k8s versions are selected? This way, it is clear to the user what should be done as they are used to it 'just working' when selecting the aws cloud provider.

This should apply in both creating rke2 clusters as well as upgrading them (if 1.27+ is selected)

x-linking the documentation PR if that is helpful for creating the banner/alert message: rancher/rancher-docs#844

we add a banner/alert box in rke1 when upgrading an aws cluster with an existing in-tree provider. Might be nice to add a link to the documentation in that case as well.

@slickwarren
Copy link
Contributor

there is now a notification displayed as of v2.8-head (a6b908d), and is working as intended when selecting the amazon option on both fresh 1.27 installs and upgrades to 1.27:
image

@gaktive
Copy link
Member

gaktive commented Jan 18, 2024

/backport v2.7.next1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment