[2.7] AWS external cloud provider support #10300
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10299
Fixes #10266
This is a backport of #9643 and #9914
Summary
UX for these issues changed from what was originally outlined in the above issues. The initial plan was to remove the aws cloud provider option for k8s versions >=1.27 (rke2 cloud provider options come from an api call, so no need to explicitly remove the option in the UI). Generalized UI code was added to handle the possibility that a user is upgrading a cluster with a cloud provider that is no longer supported.
The plan for aws external cloud provider support changed, and new UX involves selecting the 'aws' cloud provider option then adding some extra configuration. #9914 adds a banner warning the user that they need to do this.
Technical notes summary
Per offline conversations w/ Neil and Gary we're keeping the code from #9643 in our backports - though no longer relevant, it doesn't cause bugs.
Areas or cases that should be tested
When upgrading a cluster using the aws cloud provider to >=1.27, a banner should appear warning the user that they will need to supply some extra configration for the external aws cloud provider. The same banner should appear when creating a new >=1.27 cluster with the aws cloud provider selected.
2.-7head doesn't have a k8s 1.27 option available yet. You fake a 1.27 version option for testing purposes by adding code here