Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.7] AWS external cloud provider support #10300

Merged

Conversation

mantis-toboggan-md
Copy link
Member

@mantis-toboggan-md mantis-toboggan-md commented Jan 18, 2024

Fixes #10299
Fixes #10266

This is a backport of #9643 and #9914

Summary

UX for these issues changed from what was originally outlined in the above issues. The initial plan was to remove the aws cloud provider option for k8s versions >=1.27 (rke2 cloud provider options come from an api call, so no need to explicitly remove the option in the UI). Generalized UI code was added to handle the possibility that a user is upgrading a cluster with a cloud provider that is no longer supported.

The plan for aws external cloud provider support changed, and new UX involves selecting the 'aws' cloud provider option then adding some extra configuration. #9914 adds a banner warning the user that they need to do this.

Technical notes summary

Per offline conversations w/ Neil and Gary we're keeping the code from #9643 in our backports - though no longer relevant, it doesn't cause bugs.

Areas or cases that should be tested

When upgrading a cluster using the aws cloud provider to >=1.27, a banner should appear warning the user that they will need to supply some extra configration for the external aws cloud provider. The same banner should appear when creating a new >=1.27 cluster with the aws cloud provider selected.

2.-7head doesn't have a k8s 1.27 option available yet. You fake a 1.27 version option for testing purposes by adding code here

const add = JSON.parse(JSON.stringify(this.rke2Versions[this.rke2Versions.length -1]));
add.id = 'v1.27.0+rke2r1';
add.version = add.id;
this.rke2Versions.push(add);

Copy link
Member

@momesgin momesgin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mantis-toboggan-md mantis-toboggan-md merged commit 46ae558 into rancher:release-2.7 Jan 19, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants