Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add instructions for secure AWS Task IAM Roles #2015

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

sodre
Copy link

@sodre sodre commented Nov 19, 2019

The Task IAM Rules were extracted verbatim from the Amazon documentation steps 5, 6, and 7

The latter two rules were adapted from Amazon documentation so that system-docker traffic retains access to the instance-metadata, while traffic from user-docker does not.

This documentation change is not sufficient to get Task IAM Roles to work, it requires a modification to the amazon-ecs-agent service, which will follow in a separate PR to the os-services repo.

The [Task IAM Rules]  were extracted verbatim from the Amazon documentation [steps 5, 6, and 7]( https://docs.aws.amazon.com/AmazonECS/latest/developerguide/ecs-agent-install.html)

The latter two rules were adapted from [Amazon documentation](https://docs.aws.amazon.com/AmazonECS/latest/developerguide/instance_IAM_role.html) so that system-docker traffic retains access to the instance-metadata, while traffic from user-docker does not.

This documentation change is not sufficient to get Task IAM Roles to work, it requires a modification to the amazon-ecs-agent service, which will follow in a separate commit.
sodre added a commit to sodre/os-services that referenced this pull request Nov 19, 2019
According to Amazon's documentation in [step 10](https://docs.aws.amazon.com/AmazonECS/latest/developerguide/ecs-agent-install.html), the ECS-Agent is only supported if running using the Host networking instead of bridge. 

I also enabled Task IAM Role by default, to synchronize with the documentation update in rancher/docs#2015
@sodre sodre changed the title Support secure AWS Task IAM Roles Add instructions for secure AWS Task IAM Roles Nov 20, 2019
sodre added a commit to sodre/os-packer that referenced this pull request Nov 21, 2019
  - Implements the instructions in rancher/docs#2015, directly in the
ecs-optimized image.
  - Depends on rancher/os-release#217
@sodre
Copy link
Author

sodre commented Apr 3, 2020

Hi!

Any updates on getting this issue fixed?

@catherineluse
Copy link
Contributor

@SheilaghM This PR is dependent on a RancherOS change to be merged, but since RancherOS is deprecated, I'm wondering if this PR should be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants