Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update the helm rancher example #2463

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

AlphaWong
Copy link

Hi,

I find the example states in the helm instance section with some issues.
I update the helm installation example in order to fit the condition.

reference

https://github.com/rancher/rancher/blob/master/chart/templates/issuer-letsEncrypt.yaml#L4

Best,
Alpha

@catherineluse
Copy link
Contributor

@SheilaghM
If this example Helm command changes, we would probably need to make the change in many places of the docs.

The outstanding question is, should we show that the cert manager version should be specified in Helm commands?

@AlphaWong
Copy link
Author

AlphaWong commented Dec 24, 2020

@SheilaghM
If this example Helm command changes, we would probably need to make the change in many places of the docs.

The outstanding question is, should we show that the cert manager version should be specified in Helm commands?

The point is that if we do not specify the run-able version. it will hit this logic https://github.com/rancher/rancher/blob/master/chart/templates/issuer-letsEncrypt.yaml#L4
as a new joiner may not check the source code. So I think that we can offer a fixed version number to make the quick start really quick.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants