Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Build meta from kubernetes image versioning #54

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Remove Build meta from kubernetes image versioning #54

wants to merge 3 commits into from

Conversation

galal-hussein
Copy link
Contributor

@galal-hussein galal-hussein commented Mar 6, 2024 •
edited
Loading

@galal-hussein galal-hussein mentioned this pull request Mar 6, 2024
Open
brandond
brandond requested changes Mar 11, 2024
View reviewed changes
Copy link
Member

@brandond brandond left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe we need to keep the rke2 bit in the tag for Rancher's cluster type detection to work properly.

Ref: https://github.com/rancher/kubernetes-provider-detector/blob/master/providers/rke2.go#L21

@galal-hussein galal-hussein requested a review from brandond March 11, 2024 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briandowns briandowns briandowns approved these changes

@brandond brandond brandond approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@galal-hussein @brandond @briandowns