This repository has been archived by the owner on Dec 8, 2023. It is now read-only.
Retain additional files needed by update-ca-certificates as part of rootfs #818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dweomer
approved these changes
Nov 24, 2021
|
@dweomer Now that this PR has been approved, what is required before it can be merged? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #518, the
update-ca-certificatescommand on k3os doesn't work the way people expect; when runningupdate-ca-certificates, all of the default certificates are lost and only user certificates are included in the final ca-certificates bundle. There have been workarounds proposed such as copying the default ca-certificates bundle from/etc/ssl/certsinto/usr/local/share/ca-certificatesand then appending the additional CA certificates to that file before runningupdate-ca-certificates.The intended behavior for
update-ca-certificatesis that it pulls user certificates from/usr/local/share/ca-certificates, and system default certificates from/usr/share/ca-certificates; however,update-ca-certificatesdoes not automatically bundle all certificates found in/usr/share/ca-certificates- instead, it only bundles those system-default certificates listed in the configuration file/etc/ca-certificates.conf.The reason for the misbehavior of
update-ca-certificateson k3os, then, is the lack of a/etc/ca-certificates.conffile. This file is part of theca-certificatespackage in alpine (the same package that contains theupdate-ca-certificatescommand), however the k3os build process doesn't include this file by default when building the rootfs. This PR addresses that issue, ensuring that the rootfs includes all of the files needed forupdate-ca-certificatesto operate as intended.