Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support database queries on arbitrary labels #117

Open
wants to merge 17 commits into
base: main
Choose a base branch
from
Open

Support database queries on arbitrary labels #117

wants to merge 17 commits into from
+974 −206

Commits on Dec 3, 2024

  1. Support searching by metadata.label fields: 

    * Add labels when adding/replacing objects.
* Add labels to the query language
    @ericpromislow
    ericpromislow committed Dec 3, 2024
    Configuration menu
    Copy the full SHA
    a8a924b View commit details
    Browse the repository at this point in the history

  2. Add a unit test for label tests.

    @ericpromislow
    ericpromislow committed Dec 3, 2024
    Configuration menu
    Copy the full SHA
    82b7994 View commit details
    Browse the repository at this point in the history

  3. Stick with terse in-place table alias names rather than interpolate d… 

    …escriptive named constants.

Also: Move all the label operations from store to listoption_indexer.
    @ericpromislow
    ericpromislow committed Dec 3, 2024
    Configuration menu
    Copy the full SHA
    991d637 View commit details
    Browse the repository at this point in the history

  4. Run go generate after refactoring label handling.

    @ericpromislow
    ericpromislow committed Dec 3, 2024
    Configuration menu
    Copy the full SHA
    305b92b View commit details
    Browse the repository at this point in the history

  5. Move label handling out of store.go and into the listoption indexer.

    @ericpromislow
    ericpromislow committed Dec 3, 2024
    Configuration menu
    Copy the full SHA
    cbde1d8 View commit details
    Browse the repository at this point in the history

  6. Fix the number of args in the mocked calls to creating the indices ta… 

    …bles.

- tx.Exec takes only one argument.
    @ericpromislow
    ericpromislow committed Dec 3, 2024
    Configuration menu
    Copy the full SHA
    2e3a890 View commit details
    Browse the repository at this point in the history

  7. Split 'ListOptionIndexer.afterUpsert' into two funcs with more descri… 

    …ptive names.
    @ericpromislow
    ericpromislow committed Dec 3, 2024
    Configuration menu
    Copy the full SHA
    e555a6f View commit details
    Browse the repository at this point in the history

  8. Split the 'afterX' methods into two parts, with better names.

    @ericpromislow
    ericpromislow committed Dec 3, 2024
    Configuration menu
    Copy the full SHA
    ef1acd2 View commit details
    Browse the repository at this point in the history

  9. Refactor the query-generator into its own method.

    @ericpromislow
    ericpromislow committed Dec 3, 2024
    Configuration menu
    Copy the full SHA
    29f233f View commit details
    Browse the repository at this point in the history

  10. Split 'ListByOptions' into two functions to simplify testing.

    @ericpromislow
    ericpromislow committed Dec 3, 2024
    Configuration menu
    Copy the full SHA
    31a4b97 View commit details
    Browse the repository at this point in the history

  11. Add tests for converting other ops to sql stmts, fixing breakage.

    @ericpromislow
    ericpromislow committed Dec 3, 2024
    Configuration menu
    Copy the full SHA
    95274c3 View commit details
    Browse the repository at this point in the history

  12. Add more tests, fix NOT-EXISTS for labels.

    @ericpromislow
    ericpromislow committed Dec 3, 2024
    Configuration menu
    Copy the full SHA
    b8a8223 View commit details
    Browse the repository at this point in the history

  13. Code quality changes: 

    - Fixed rendering NOT-EXISTS queries.
- Wrap query error in a 'db.QueryError' object.
- Use consistent error message when failing to get a unstructured object.
- Don't include ORDER-BY clauses in COUNT queries.
- Don't bother pulling the various fields out of the `queryInfo` struct
- Pull the count queryInfo parts out only when needed.
    @ericpromislow
    ericpromislow committed Dec 3, 2024
    Configuration menu
    Copy the full SHA
    3257e61 View commit details
    Browse the repository at this point in the history

  14. Simplify the way the final queryInfo struct is built. 

    In particular, don't clear the count query values if no
count query needs to be made -- just leave the default struct
values, and the query executor won't run a count-query.
    @ericpromislow
    ericpromislow committed Dec 3, 2024
    Configuration menu
    Copy the full SHA
    e908e62 View commit details
    Browse the repository at this point in the history

  15. No need to map nil to an empty array when there's no count query.

    @ericpromislow
    ericpromislow committed Dec 3, 2024
    Configuration menu
    Copy the full SHA
    8501428 View commit details
    Browse the repository at this point in the history

  16. Process comparisons in the query strings.

    @ericpromislow
    ericpromislow committed Dec 3, 2024
    Configuration menu
    Copy the full SHA
    8cb2364 View commit details
    Browse the repository at this point in the history

Commits on Dec 4, 2024

  1. Allow exist-tests on filters only on labels.

    @ericpromislow
    ericpromislow committed Dec 4, 2024
    Configuration menu
    Copy the full SHA
    15adcaa View commit details
    Browse the repository at this point in the history