Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#991 Update AWS info about setting up cloud provider #1112

Conversation

martyav
Copy link
Contributor

@martyav martyav commented Feb 8, 2024

Related to #991

Reminders

  • See the README for more details on how to work with the Rancher docs.

  • Verify if changes pertain to other versions of Rancher. If they do, finalize the edits on one version of the page, then apply the edits to the other versions.

  • If the pull request is dependent on an upcoming release, make sure to target the release branch instead of main.

Description

#991 (comment)

From Slack:

AWS cloud provider docs are definitely looking better than the state I left them in so I thank you for that, I do have a suggestion though. On https://ranchermanager.docs.rancher.com/how-to-guides/new-user-guides/kubernetes-clusters-in[…]-of-tree-cloud-provider/migrate-to-out-of-tree-amazon, the following line:

If it's acceptable to have some downtime, you can switch to an external cloud provider, which removes in-tree components and then deploy charts to install the AWS cloud controller manager.

reads like it's optional. I think I wrote it initially but now that I'm looking at it with fresh eyes, it doesn't really make sense. The link is for setting up the external cloud-provider on a fresh cluster, so I feel like the sentence should read something like:

If it's acceptable to have some downtime during migration, you can follow the cluster external amazon cloud provider documentation which outlines how to configure the out of tree provider for a newly provisioned cluster. There will be a period where specific cloud-provider functionality is unavailable within your cluster, as there will effectively be no cloud-provider running until the out of tree provider is functional.

Or something to that effect.
In addition, it kind of makes it seem like the only thing needed is to enable leader-migration, but that doesn't really make sense in this context because one would still need to follow all the RKE2 steps from https://ranchermanager.docs.rancher.com/how-to-guides/new-user-guides/kubernetes-clusters-in-rancher-setup/set-up-cloud-providers/amazon#usin[…]ider. Not suggesting anything specifically, I'm fine if we just duplicate the docs to the migration page or if we link and say "here is what must be done before", then link to the steps, and then "here is what must be done afterwards" or something. WDYT?

Comments

@martyav
Copy link
Contributor Author

martyav commented Feb 8, 2024

I think this will also have to be added to the 2.7 content for the upcoming 2.7.11 release. There's already an open PR, #1080, backporting other relevant changes re: Kubernetes 1.27 support (1.27 necessitates using the out-of-tree provider)

Copy link
Contributor

@sunilarjun sunilarjun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Phrasing looks good, thanks Marty!

Copy link
Contributor

@LucasSaintarbor LucasSaintarbor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT 👍

@martyav martyav merged commit 2e14230 into rancher:main Feb 12, 2024
1 check passed
martyav added a commit to martyav/rancher-docs that referenced this pull request Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants