-
Notifications
You must be signed in to change notification settings - Fork 223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[2.10.0] - Update SAML Pages with SLO Feature #1335
Conversation
…in Okta SAML page. Updating to other SAML pages currently after UX PR was finalized. Signed-off-by: Sunil Singh <[email protected]>
Since we have so many "Merge on release" PRs for 2.9.0 and 2.8.6, I'm going to remove the label and add a "DO NOT MERGE" so that there's less confusion on the next release day |
Hello @aalves08! I am not able to tag you as a reviewer but would you be able to look over the content addition and see if there is anything missing or that needs to be adjusted for the configuration steps, thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this is applicable to all SAML providers, Microsoft AD FS and Shibboleth are missing.
Not a blocker, but since this block is repeated multiple times per version it may be worth putting it in a partial/shared-files (similar to #1142) to keep things DRY.
…th SAML pages. Signed-off-by: Sunil Singh <[email protected]>
Signed-off-by: Sunil Singh <[email protected]>
@btat Added the content to Microsoft AD FS/Shibboleth/translation pages, as well as added _configure-slo.md file to shared files to go the partial route, thanks for reviewing! |
@sunilarjun can you update the base branch to v2.10.0 so that we don't publish the changes to /docs right away when this gets merged. Everything else LGTM. Will submit approval after the base change. |
@btat Just updated base branch, thanks for catching! |
@sunilarjun, sorry for the late reply, but I've been held up with other topics The If the Probably worth mentioning because it may reduce number of support issues being filed 🙏 |
That's perfect @sunilarjun 🙏 Thank you 🙇 |
Added information regarding new feature SAML SLO configuration through Rancher UI in SAML pages. Rancher issue link for reference: rancher/dashboard#10941
Fixes docs issue #1331