Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add info for aws cloud provider #826

Closed
wants to merge 1 commit into from
Closed

Add info for aws cloud provider #826

wants to merge 1 commit into from

Conversation

kinarashah
Copy link
Member

@kinarashah kinarashah commented Sep 7, 2023 •
edited by snasovich
Loading

@kinarashah kinarashah requested a review from superseb September 7, 2023 01:44
@martyav
Copy link
Contributor

martyav commented Sep 7, 2023 •
edited
Loading

@kinarashah is this related to #814 and/or #763?

@martyav
Copy link
Contributor

martyav commented Sep 7, 2023

@kinarashah if the AWS out of tree stuff is tied to the v2.8 release, we should make this PR target the v2.8 branch instead of main.

@snasovich
Copy link

@martyav , updated the description to link to proper issues.
Please note that @kinarashah is out for the next few weeks so please direct questions to me.

Meanwhile, on the branch should we be targeting https://github.com/rancher/rancher-docs/tree/2023-Q4-2.8x then?

@martyav martyav changed the base branch from main to 2023-Q4-2.8x September 13, 2023 14:50
@martyav martyav added the next-release This PR is tied to the next Rancher release and should take higher priority label Sep 13, 2023
@Sahota1225 Sahota1225 mentioned this pull request Sep 14, 2023
Closed
@jakefhyde jakefhyde mentioned this pull request Sep 14, 2023
Merged
martyav
martyav suggested changes Sep 15, 2023
View reviewed changes
...guides/new-user-guides/kubernetes-clusters-in-rancher-setup/set-up-cloud-providers/amazon.md Show resolved Hide resolved
...guides/new-user-guides/kubernetes-clusters-in-rancher-setup/set-up-cloud-providers/amazon.md Show resolved Hide resolved
...guides/new-user-guides/kubernetes-clusters-in-rancher-setup/set-up-cloud-providers/amazon.md Show resolved Hide resolved
...guides/new-user-guides/kubernetes-clusters-in-rancher-setup/set-up-cloud-providers/amazon.md Show resolved Hide resolved
...guides/new-user-guides/kubernetes-clusters-in-rancher-setup/set-up-cloud-providers/amazon.md Show resolved Hide resolved
...guides/new-user-guides/kubernetes-clusters-in-rancher-setup/set-up-cloud-providers/amazon.md Show resolved Hide resolved
...guides/new-user-guides/kubernetes-clusters-in-rancher-setup/set-up-cloud-providers/amazon.md Show resolved Hide resolved
...guides/new-user-guides/kubernetes-clusters-in-rancher-setup/set-up-cloud-providers/amazon.md Show resolved Hide resolved
...guides/new-user-guides/kubernetes-clusters-in-rancher-setup/set-up-cloud-providers/amazon.md Show resolved Hide resolved
...guides/new-user-guides/kubernetes-clusters-in-rancher-setup/set-up-cloud-providers/amazon.md Show resolved Hide resolved
@jakefhyde
Copy link
Contributor

Closing in favor of #844.

@jakefhyde jakefhyde closed this Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@superseb superseb superseb left review comments

@jakefhyde jakefhyde jakefhyde left review comments

@martyav martyav martyav requested changes

Assignees
No one assigned
Labels
next-release This PR is tied to the next Rancher release and should take higher priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kinarashah @martyav @snasovich @jakefhyde @superseb