CNI chart docs tweaks #324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dereknola
requested changes
Feb 3, 2025
brandond
force-pushed
the
cni-chart-tweaks
branch
from
067d74f to
47a8b54
Compare
Signed-off-by: Brad Davidson <[email protected]>
brandond
force-pushed
the
cni-chart-tweaks
branch
from
47a8b54 to
5efb318
Compare
dereknola
approved these changes
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modify the RKE2 CNI docs based on feedback from a confused user in #323
Mention the
cniconfig file key more prominently, and make it more explicit how charts are bundled. Also drop references to CLI flags, since we are standardizing on only referencing the config file in docs.