-
Notifications
You must be signed in to change notification settings - Fork 275
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
validate-charts runs as part of 'make validate' step and checks that all images used in packaged charts: - use systemGlobalRegistry - are present in script/build-images Signed-off-by: Thomas Ferrandiz <[email protected]>
- Loading branch information
1 parent
0f71c9a
commit 05c0516
Showing
8 changed files
with
199 additions
and
23 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| #!/usr/bin/env bash | ||
|
|
||
| set -eux -o pipefail | ||
|
|
||
| while read version filename bootstrap; do | ||
| CHART_VERSION=$version CHART_FILE=$filename CHART_BOOTSTRAP=$bootstrap /charts/build-chart.sh | ||
| done <<< $(yq e '.charts[] | [.version, .filename, .bootstrap] | join(" ")' /charts/chart_versions.yaml) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,46 @@ | ||
| charts: | ||
| - version: 1.14.100 | ||
| filename: /charts/rke2-cilium.yaml | ||
| bootstrap: true | ||
| - version: v3.26.1-build2023080200 | ||
| filename: /charts/rke2-canal.yaml | ||
| bootstrap: true | ||
| - version: v3.26.101 | ||
| filename: /charts/rke2-calico.yaml | ||
| bootstrap: true | ||
| - version: v3.26.101 | ||
| filename: /charts/rke2-calico-crd.yaml | ||
| bootstrap: true | ||
| - version: 1.24.004 | ||
| filename: /charts/rke2-coredns.yaml | ||
| bootstrap: true | ||
| - version: 4.6.100 | ||
| filename: /charts/rke2-ingress-nginx.yaml | ||
| bootstrap: false | ||
| - version: 2.11.100-build2023051509 | ||
| filename: /charts/rke2-metrics-server.yaml | ||
| bootstrap: false | ||
| - version: v4.0.2-build2023081100 | ||
| filename: /charts/rke2-multus.yaml | ||
| bootstrap: true | ||
| - version: 1.5.100 | ||
| filename: /charts/rancher-vsphere-cpi.yaml | ||
| bootstrap: true | ||
| - version: 3.0.1-rancher101 | ||
| filename: /charts/rancher-vsphere-csi.yaml | ||
| bootstrap: true | ||
| - version: 0.2.200 | ||
| filename: /charts/harvester-cloud-provider.yaml | ||
| bootstrap: true | ||
| - version: 0.1.1600 | ||
| filename: /charts/harvester-csi-driver.yaml | ||
| bootstrap: true | ||
| - version: 1.7.202 | ||
| filename: /charts/rke2-snapshot-controller.yaml | ||
| bootstrap: false | ||
| - version: 1.7.202 | ||
| filename: /charts/rke2-snapshot-controller-crd.yaml | ||
| bootstrap: false | ||
| - version: 1.7.300 | ||
| filename: /charts/rke2-snapshot-validation-webhook.yaml | ||
| bootstrap: false |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,131 @@ | ||
| #!/usr/bin/env bash | ||
| set -e | ||
|
|
||
| info() { | ||
| echo '[INFO] ' "$@" | ||
| } | ||
|
|
||
| error() { | ||
| echo '[ERROR] ' "$@" >&2 | ||
| } | ||
|
|
||
| fatal() { | ||
| echo '[ERROR] ' "$@" >&2 | ||
| exit 1 | ||
| } | ||
|
|
||
| cleanup() { | ||
| exit_code=$? | ||
| trap - EXIT INT | ||
| rm -rf /tmp/tmp.*.tar.gz | ||
| exit ${exit_code} | ||
| } | ||
| trap cleanup EXIT INT | ||
|
|
||
|
|
||
| download_chart() { | ||
| chart_version=$1 | ||
| chart_name=$2 | ||
| bootstrap=$3 | ||
|
|
||
| chart_package=${chart_name%%-crd} | ||
|
|
||
| chart_url=${CHART_REPO:="https://rke2-charts.rancher.io"}/assets/${chart_package}/${chart_name}-${chart_version:="v0.0.0"}.tgz | ||
|
|
||
| chart_tmp=$(mktemp --suffix .tar.gz) | ||
|
|
||
| curl -fsSL "${chart_url}" -o "${chart_tmp}" | ||
|
|
||
| echo $chart_tmp | ||
| } | ||
|
|
||
| check_system_registry() { | ||
| chart_version=$1 | ||
| chart_name=$2 | ||
| chart_tmp=$3 | ||
|
|
||
| yaml_tmp=$(mktemp --suffix .yaml) | ||
| values="global.systemDefaultRegistry=my-registry,global.cattle.systemDefaultRegistry=my-registry,vCenter.clusterId=test-id" | ||
| helm template test-chart --set $values $chart_tmp > $yaml_tmp; | ||
|
|
||
| awk '$1 ~ /^image:/ { | ||
| if( $2 !~ /my-registry/ && $2 !~ busybox) { | ||
| print $2 | ||
| } | ||
| } | ||
| ' $yaml_tmp | ||
| } | ||
|
|
||
| check_airgap() { | ||
| chart_version=$1 | ||
| chart_name=$2 | ||
| chart_tmp=$3 | ||
|
|
||
| # skip rancher-vsphere-cpi because it doesn't work well with `helm template` | ||
| if [[ $chart_name == 'rancher-vsphere-cpi' ]]; then | ||
| return 0 | ||
| fi | ||
|
|
||
| yaml_tmp=$(mktemp --suffix .yaml) | ||
| values="vCenter.clusterId=test-id" | ||
| helm template test-chart --set $values $chart_tmp > $yaml_tmp; | ||
|
|
||
| awk '$1 ~ /^image:/ { | ||
| gsub(/"/, "", $2) | ||
| gsub(/^docker.io/, "", $2) | ||
| print $2 | ||
| } | ||
| ' $yaml_tmp | \ | ||
| while read image | ||
| do | ||
| [ "$image" = "busybox" ] && continue | ||
| if ! grep -q $image scripts/build-images; then | ||
| echo $image | ||
| fi | ||
| done | ||
| } | ||
|
|
||
| declare -A NO_SYSTEM_REGISTRY | ||
| declare -A NOT_FOUND | ||
|
|
||
|
|
||
| while read version filename bootstrap; do | ||
| chart_name=$(basename "${filename%%.yaml}") | ||
| chart_tmp=$(download_chart $version $chart_name $bootstrap) | ||
|
|
||
| info "Validating chart $chart_name, version $version..." | ||
|
|
||
| no_system_registry=$(check_system_registry $version $chart_name $chart_tmp) | ||
| if ! [ -z "$no_system_registry" ]; then | ||
| NO_SYSTEM_REGISTRY[$chart_name]=$no_system_registry | ||
| fi | ||
|
|
||
| not_found=$(check_airgap $version $chart_name $chart_tmp) | ||
| if ! [ -z "$not_found" ]; then | ||
| NOT_FOUND[$chart_name]=$not_found | ||
| fi | ||
| done <<< $(yq e '.charts[] | [.version, .filename, .bootstrap] | join(" ")' charts/chart_versions.yaml) | ||
|
|
||
| failed=0 | ||
|
|
||
| if [ ${#NO_SYSTEM_REGISTRY[@]} -ge 1 ]; then | ||
| failed=1 | ||
| for chart in "${!NO_SYSTEM_REGISTRY[@]}" | ||
| do | ||
| error "Images not using global.systemDefaultRegistry in chart '$chart': ${NO_SYSTEM_REGISTRY[$chart]}" | ||
| done | ||
| error "Please use global.systemDefaultRegistry for above images" | ||
| fi | ||
|
|
||
| if [ ${#NOT_FOUND[@]} -ge 1 ]; then | ||
| failed=1 | ||
| for chart in "${!NOT_FOUND[@]}" | ||
| do | ||
| error "Missing images for chart '$chart': ${NOT_FOUND[$chart]}" | ||
| done | ||
| error "Please include above images in build-images" | ||
| fi | ||
|
|
||
| [ $failed = 1 ] && fatal "Please fix the issues above" | ||
|
|
||
| exit 0 |