Skip to content

Commit

Permalink
Adr for kine support
Browse files Browse the repository at this point in the history
Signed-off-by: Vitor Savian <[email protected]>
  • Loading branch information
vitorsavian committed Mar 20, 2024
1 parent 0a03dad commit 6acc89c
Showing 1 changed file with 44 additions and 0 deletions.
44 changes: 44 additions & 0 deletions docs/adrs/007-add-kine-support.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,44 @@
# Add kine support to RKE2

## Established

## Revisit by

## Status

Proposed

## Context

This ADR is a introduction of kine support for RKE2. However, for this support to be implemented, it was necessary to add kine with TLS in K3s.
Which was done in this [PR](https://github.com/k3s-io/k3s/pull/9572), It was needed since rke2 cannot connect to kine without tls via the api server.

### Pros

- With the integration of kine, it is now possible to use the `--datastore-endpoint` flag among others related to kine. This allows for a more versatile configuration of the datastore,
providing users with the flexibility to choose their preferred storage backend.

### Cons

- Kine can only be utilized with TLS due to the requirements of the API server.

## Other changes needed in k3s to better support kine in rke2

When testing rke2 with kine, there was some changes to avoid panics (specially when we are talking about `etcd`) and to make it work with tls. The changes are that when the user
uses `--database-endpoint` and other flags related to `etcd only` nodes, we have to ignore this flags or simply ending the process with a error message.

#### Pros of Ignoring the flags

- It is possible to avoid panics and rke2 will run as spected.

#### Cons of Ignoring the flags

- It will be not very clear to the user that the flags are being ignored.

#### Pros of Ending the process with a error message

- Rke2 will run as spected with transparency to the user.

#### Cons of Ending the process with a error message

- The user will have to change the flags to make rke2 run.

0 comments on commit 6acc89c

Please sign in to comment.