Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix validate-chart scripts #5160

Merged

Conversation

thomasferrandiz
Copy link
Contributor

@thomasferrandiz thomasferrandiz commented Dec 22, 2023

  • clean-up temp yaml file
  • fix k8s version check
  • fix rke2-coredns templating

Linked issue: #5371

Proposed Changes

Types of Changes

Verification

Testing

Linked Issues

User-Facing Change


Further Comments

@thomasferrandiz thomasferrandiz requested a review from a team as a code owner December 22, 2023 15:18
@thomasferrandiz thomasferrandiz changed the title fix validate-chart scripts: fix validate-chart scripts Dec 22, 2023
scripts/validate-charts Outdated Show resolved Hide resolved
scripts/validate-charts Outdated Show resolved Hide resolved
@thomasferrandiz thomasferrandiz force-pushed the fix-validation-script branch 5 times, most recently from 64eec92 to 0fb30c4 Compare January 10, 2024 15:24
- clean-up temp yaml file
- fix k8s version check
- fix rke2-coredns templating
- test for busybox image normally
- fix missing airgap image in multus

Signed-off-by: Thomas Ferrandiz <[email protected]>
@thomasferrandiz thomasferrandiz merged commit c0f459a into rancher:master Feb 8, 2024
2 checks passed
@thomasferrandiz thomasferrandiz deleted the fix-validation-script branch November 7, 2024 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants