[windows] Improve kube-proxy logging and move calico logs to a better path

[manuelbuil]

Proposed Changes

Following on from what we do with Calico processes, use a file to dump the logs of kube-proxy in windows. The current Stdout and Stderr output is supposed to be piped to the Windows Logging System but it does not work. Using a file instead works.

This PR also moves Calico logs to the same place where kubelet logs are. That place is C:\var\lib\rancher\rke2\agent\logs which makes much more sense

Types of Changes

Bugfix

Verification

Check issue

Testing

Linked Issues

#5247

User-Facing Change

Further Comments

[brandond]

The default kubelet log for linux is /var/lib/rancher/rke2/agent/logs/kubelet.log, why do we use c:/var/log for this instead of c:/var/lib/rancher/rke2/agent/logs? Can we just put this in the same place as the kubelet log?

rke2/pkg/cli/defaults/defaults.go

Line 15 in 86dc12b

logsDir := filepath.Join(dataDir, "agent", "logs")

rke2/pkg/cli/defaults/defaults.go

Line 39 in 86dc12b

"log-file=" + filepath.Join(logsDir, "kubelet.log"),

[manuelbuil]

AH! I missed that already existing path! Thanks Brad! I'm actually going to move calico logs to there as well, I think it makes much more sense

[brandond]

I would recommend reusing or at least duplicating the code that we use to capture kubelet logs using lumberjack, which handles rotating and pruning logs. Otherwise this one log file may get very large.

rke2/pkg/logging/logging.go

Lines 38 to 40 in f2396b6

	// ExtractFromArgs extracts the legacy klog flags from an args list, and returns both the remaining args,
	// and a similarly configured log writer configured using the klog flag values.
	func ExtractFromArgs(args []string) ([]string, io.Writer) {

[manuelbuil]

good idea! I was actually wondering if these logs could get too large. I was not aware of this lumberjack library