Add flannel CNI plugin #5322
Merged
Add flannel CNI plugin #5322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manuelbuil
force-pushed
the
addFlannelWin3
branch
from
5fec81b to
f62faa4
Compare
|
Does this build on #5276? |
|
GitHub doesn't have proper support for stacked PRs yet, unfortunately... so the best you can do is just call out in the comments that it's depending on another PR:
Ref: https://blog.logrocket.com/using-stacked-pull-requests-in-github/ |
thomasferrandiz
approved these changes
Jan 26, 2024
manuelbuil
force-pushed
the
addFlannelWin3
branch
3 times, most recently
from
c36e63e to
65d11da
Compare
Signed-off-by: Manuel Buil <[email protected]>
manuelbuil
force-pushed
the
addFlannelWin3
branch
from
65d11da to
b89668f
Compare
dereknola
approved these changes
Feb 8, 2024
This was referenced Feb 9, 2024
|
This PR should be tested together with #5421 which fixes a few minor issues |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
This PR adds flannel CNI plugin as an option for rke2. The reasoning is covered in the adr: #5145
Please only review the commit Add CNI plugin flannel support for Windows. The other one is covered in the PR: #5276, which abstracts the interface so that more CNI plugins can be used
Types of Changes
New feature
Verification
Use
cni: flannelwhen deploying rke2Testing
Linked Issues
#5215
User-Facing Change
Further Comments