Remove kube-proxy static pod manifest during agent bootstrap #5619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Brad Davidson <[email protected]>
brandond
force-pushed
the
delay-kube-proxy-static-pod
branch
from
a1fbc66 to
93af5cc
Compare
brandond
changed the title
dereknola
approved these changes
Mar 15, 2024
galal-hussein
approved these changes
Mar 22, 2024
This was referenced Apr 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Clean up kube-proxy during agent bootstrap
If the static pod manifest isn't present during kubelet startup, it won't try to reconcile it until later, after the apiserver is up - which should address whatever weird race condition we've been running into with the volume mounts.
I haven't been able to figure out where exactly in the guts of the kubelet PLEG reconcile loop the volume mounts are getting mangled; all I know is that it appears to be a race condition between the kubelet reading the static pod manifest, and finding the mirror pod from the apiserver. Best we can do is try to avoid triggering it I guess.
Types of Changes
bugfix
Verification
See linked issue
Testing
Linked Issues
User-Facing Change
Further Comments