Bump flannel version #5638
Merged
Bump flannel version #5638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Manuel Buil <[email protected]>
manuelbuil
force-pushed
the
updateFlannel
branch
from
217ff4e to
99d543c
Compare
vitorsavian
approved these changes
Mar 25, 2024
dereknola
approved these changes
Mar 25, 2024
brandond
approved these changes
Mar 25, 2024
|
@manuelbuil not sure if you saw the comment at flannel-io/flannel#1907 (comment) Is there any particular reason we didn't just use the same tolerations as other charts? For example: |
|
Thanks @brandond for the heads up. Yes, he opened an issue too and we discussed over there flannel-io/flannel#1921. Basically, same answer as you did |
This was referenced Mar 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Bump flannel version
Types of Changes
Bump version. Fixes a bug, described in issue
Verification
Check issue
Testing
Linked Issues
#5637
#5629
User-Facing Change
Further Comments