Improve how flannel-windows reserves an IP for kube-proxy vip #5661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Manuel Buil <[email protected]>
brandond
approved these changes
Apr 2, 2024
thomasferrandiz
approved these changes
Apr 3, 2024
This was referenced Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
This PR improves two steps:
1 - We move from "cniVersion": "0.2.0", to "cniVersion": "1.0.0" which requires a change in the SourceVipResponse struct
2 - Moved "vxlan0" host-local network to "flannel.4096", so that it is in sync with the flannel network in Windows
3 - Use strings different from "dummy" which confuses support people (understandably)
Types of Changes
Kind of bugfix
Verification
In the windows node, check /var/lib/network/cni/ and make sure there is no vxlan0 directory but only a flannel.4096. Then, verify that the reserved IP for kube-proxy (you can check it in the windows logs with "Reserved VIP for kube-proxy: $IP" is there and the content is:
Testing
Linked Issues
#5662
User-Facing Change
Further Comments