Add extra information in install.ps1 to help users #5690
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Manuel Buil <[email protected]>
brandond
requested changes
Apr 8, 2024
| @@ -726,7 +726,7 @@ switch ($Method) { | |||
| Install-AirgapTarball -CommitHash $Commit -InstallAgentImageDir $AgentImagesDir -TempAirgapTarball $TMP_AIRGAP_TARBALL -ExpectedImageAirgapChecksum $AIRGAP_CHECKSUM_EXPECTED -TempImageChecksums $TMP_AIRGAP_CHECKSUMS | |||
| Test-TarballChecksum -Tarball $TMP_BINARY_TARBALL -ExpectedChecksum $BINARY_CHECKSUM_EXPECTED | |||
| Expand-Tarball -InstallPath $TarPrefix -Tarball $TMP_BINARY_TARBALL | |||
| Write-InfoLog "install complete; you may want to run: `$env:PATH+=`";$TarPrefix\bin;C:\var\lib\rancher\rke2\bin`"" | |||
| Write-InfoLog "install complete; you may want to run: `$env:PATH+=`";$TarPrefix\bin;C:\var\lib\rancher\rke2\bin`" or use [System.Environment]::SetEnvironmentVariable if rke2 will run as a service" | |||
There was a problem hiding this comment.
Under what circumstances would rke2 not run as a service? I don't think anyone is out there running rke2 agents from the command prompt.
Do we need some changes to properly set up the environment for the service when installing it, so that the correct paths are in its environment without any additional action from the user?
There was a problem hiding this comment.
You mean adding it as part of the RKE2 windows code? Probably a better approach and we forget about changing the PATH. Let me see how we could do this
There was a problem hiding this comment.
Found the culprit! #5698
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
RKE2 docs already explain that the $PATH should be set with
[System.Environment]::SetEnvironmentVariablebut the current installation.ps1 is not specifying that. Therefore, a user might set the PATH as explained in the script and still see problems because rke2 can't find containerd in the PATH. This PR adds some extra informationTypes of Changes
Docs
Verification
No need
Testing
Linked Issues
User-Facing Change
Further Comments