Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.29] windows changes #5919

Merged
merged 1 commit into from
May 17, 2024
Merged

Conversation

HarrisonWAffel
Copy link
Contributor

Proposed Changes

Types of Changes

Verification

Testing

Linked Issues

User-Facing Change


Further Comments

@HarrisonWAffel HarrisonWAffel requested a review from a team as a code owner May 17, 2024 00:07
Signed-off-by: Harrison Affel <[email protected]>
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 37.50000% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 26.49%. Comparing base (0b6eaa7) to head (ea8be56).

Files Patch % Lines
pkg/cli/defaults/defaults_linux.go 50.00% 3 Missing ⚠️
pkg/cli/defaults/defaults.go 0.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##           release-1.29    #5919      +/-   ##
================================================
+ Coverage         26.46%   26.49%   +0.03%     
================================================
  Files                30       31       +1     
  Lines              2649     2657       +8     
================================================
+ Hits                701      704       +3     
- Misses             1903     1907       +4     
- Partials             45       46       +1     
Flag Coverage Δ
inttests 9.97% <0.00%> (-0.04%) ⬇️
unittests 18.85% <37.50%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@brandond brandond merged commit 121802f into rancher:release-1.29 May 17, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants