Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ctr to shell completion #6709

Merged

Conversation

vitorsavian
Copy link
Member

Proposed Changes

  • Export the containerd.sock to the $CONTAINERD_ADDRESS env variable to use
    ctr without the need to use --address /run/k3s/containerd/containerd.sock

Types of Changes

  • New Feature

Verification

  • run rke2 and use the command
rke2 completion bash -i --ctr
  • while rke2 is running
ctr --namespace k8s.io container ls

Testing

Linked Issues

User-Facing Change


Further Comments

Signed-off-by: Vitor Savian <[email protected]>
@vitorsavian vitorsavian requested a review from a team as a code owner September 4, 2024 08:26
@codecov-commenter
Copy link

codecov-commenter commented Sep 4, 2024

Codecov Report

Attention: Patch coverage is 0% with 13 lines in your changes missing coverage. Please review.

Project coverage is 25.11%. Comparing base (e5caf09) to head (3f839c7).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
pkg/cli/cmds/completion.go 0.00% 13 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6709      +/-   ##
==========================================
- Coverage   25.18%   25.11%   -0.08%     
==========================================
  Files          33       33              
  Lines        2831     2839       +8     
==========================================
  Hits          713      713              
- Misses       2071     2079       +8     
  Partials       47       47              
Flag Coverage Δ
inttests 9.54% <0.00%> (-0.03%) ⬇️
unittests 17.75% <0.00%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vitorsavian vitorsavian requested a review from a team September 4, 2024 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants