Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only clean up pod filesystems if umount succeeds #7134

Merged
merged 1 commit into from
Oct 30, 2024

Conversation

brandond
Copy link
Member

@brandond brandond commented Oct 24, 2024

Proposed Changes

Only clean up pod filesystems if umount succeeds.

If the unmount fails for some reason we shouldn't rm -rf the mountpoint, there might still be stuff under it.

Types of Changes

killall script; bugfix

Verification

See linked issue

Testing

Linked Issues

User-Facing Change

Further Comments

@brandond brandond requested a review from a team as a code owner October 24, 2024 20:11
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 16.62%. Comparing base (26e1146) to head (9c7029d).
Report is 4 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7134   +/-   ##
=======================================
  Coverage   16.62%   16.62%           
=======================================
  Files          32       32           
  Lines        3423     3423           
=======================================
  Hits          569      569           
  Misses       2812     2812           
  Partials       42       42           
Flag Coverage Δ
unittests 16.62% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@brandond
Copy link
Member Author

brandond commented Oct 24, 2024

I will note that we do the same thing much more concisely in k3s, although it requires xargs which we have so far avoided requiring for RKE2.

https://github.com/k3s-io/k3s/blob/v1.31.1%2Bk3s1/install.sh#L839-L845

@brandond brandond merged commit abfac1f into rancher:master Oct 30, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants