Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump coredns chart to 1.33.005: #7266

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

thomasferrandiz
Copy link
Contributor

@thomasferrandiz thomasferrandiz commented Nov 12, 2024

Proposed Changes

Bump rke2-coredns chart.

The only change is that we don't set force_tcp in node-local-dns configmap anymore.
This follows the upstream manifest default configuration.

Types of Changes

Bugfix

Verification

  • deploy rke2 with nodelocaldns activated:
# /var/lib/rancher/rke2/server/manifests/rke2-coredns-config.yaml
---
apiVersion: helm.cattle.io/v1
kind: HelmChartConfig
metadata:
  name: rke2-coredns
  namespace: kube-system
spec:
  valuesContent: |-
    nodelocal:
      enabled: true
  • check that the configmap node-local-dns is created
  • check that it has the following block
.:53 { 
    errors
    cache 30
    reload
    loop
    bind 169.254.20.10 10.43.0.10
    forward . __PILLAR__UPSTREAM__SERVERS__
}

Testing

Linked Issues

#7265

User-Facing Change

When using node-local-dns, the default configuration now has `force_tcp` disabled for port 53.

Further Comments

@thomasferrandiz thomasferrandiz requested a review from a team as a code owner November 12, 2024 16:54
@codecov-commenter
Copy link

codecov-commenter commented Nov 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 16.84%. Comparing base (e4d305e) to head (757a524).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7266      +/-   ##
==========================================
+ Coverage    8.99%   16.84%   +7.85%     
==========================================
  Files          33       32       -1     
  Lines        3392     3377      -15     
==========================================
+ Hits          305      569     +264     
+ Misses       3064     2766     -298     
- Partials       23       42      +19     
Flag Coverage Δ
inttests ?
unittests 16.84% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dereknola
Copy link
Member

You can rebase now and E2E CI should pass

- don't set force_tcp in node-local-dns configmap
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants