Restore AWS node-name support and add IMDSv2 support #7343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 89a8d81. Signed-off-by: Brad Davidson <[email protected]>
dereknola
approved these changes
Nov 26, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7343 +/- ##
==========================================
- Coverage 23.70% 23.23% -0.48%
==========================================
Files 33 33
Lines 3392 3461 +69
==========================================
Hits 804 804
- Misses 2541 2609 +68
- Partials 47 48 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
brandond
force-pushed
the
restore-aws-hostname
branch
2 times, most recently
from
d6ed8af to
030b9d2
Compare
For now, the new flag is automatically set when cloud-provider-name=aws, but this will be removed in the future following our normal deprecation timeline. This also adds IMDSv2 support, and support for setting the hostname on windows. Signed-off-by: Brad Davidson <[email protected]>
brandond
force-pushed
the
restore-aws-hostname
branch
from
030b9d2 to
4cc40ce
Compare
vitorsavian
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
--node-name-from-cloud-provider-metadataflag to replace the node-name functionality previously enabled by setting--cloud-provider-name=awsTypes of Changes
Revert / enhancement
Verification
--cloud-provider-name=awson EC2; note that node name is properly set and kubelet does not crash due to--cloud-provider=awsbeing passed in kubelet args.--node-name-from-cloud-provider-metadataon EC2; note that node name is properly set.Testing
Linked Issues
awscloud-provider helpers functions #6626--cloud-provider-name=awsis recommended by Rancher docs even when deploying out-of-tree aws cloud provider #7336User-Facing Change
Further Comments