Bump dns-node-cache to 1.24.0 #7417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7417 +/- ##
=======================================
Coverage 23.23% 23.23%
=======================================
Files 33 33
Lines 3461 3461
=======================================
Hits 804 804
Misses 2609 2609
Partials 48 48
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
brandond
approved these changes
Dec 11, 2024
|
Error: ASICS] + echo '[ERROR] Failed airgap image check' Is that just a flake? seems weird it'd pass on arm64 but fail on amd64 |
cwayne18
approved these changes
Dec 11, 2024
|
I think we need to bump the coredns chart as well maybe? |
|
I'm too dumb to know exactly where to bump it but it looks like it does need a chart change: https://github.com/rancher/rke2-charts/blob/b23470de7aa96ba4cb281fe1e6f50c3758d08441/packages/rke2-coredns/generated-changes/patch/values.yaml.patch#L174 |
Signed-off-by: Derek Nola <[email protected]>
dereknola
force-pushed
the
dns-node-cache-dec
branch
from
1bd424c to
319a061
Compare
Signed-off-by: Derek Nola <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Upstream has released a new dns-node-cache (after 6 months) that fixes about 10 CVEs.
Types of Changes
Dependency Bump
Verification
Testing
Linked Issues
TBD
User-Facing Change
Further Comments