-
Notifications
You must be signed in to change notification settings - Fork 284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix-extramount-type #7423
Merged
Merged
fix-extramount-type #7423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7423 +/- ##
=======================================
Coverage 23.23% 23.23%
=======================================
Files 33 33
Lines 3461 3461
=======================================
Hits 804 804
Misses 2609 2609
Partials 48 48
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
brandond
approved these changes
Dec 12, 2024
brandond
reviewed
Dec 12, 2024
brandond
approved these changes
Dec 13, 2024
vitorsavian
approved these changes
Jan 10, 2025
brandond
pushed a commit
to brandond/rke2
that referenced
this pull request
Jan 13, 2025
* fix-extramount-type (cherry picked from commit 2bc648d) Signed-off-by: Brad Davidson <[email protected]>
brandond
pushed a commit
to brandond/rke2
that referenced
this pull request
Jan 13, 2025
* fix-extramount-type (cherry picked from commit 2bc648d) Signed-off-by: Brad Davidson <[email protected]>
brandond
pushed a commit
to brandond/rke2
that referenced
this pull request
Jan 14, 2025
* fix-extramount-type (cherry picked from commit 2bc648d) Signed-off-by: Brad Davidson <[email protected]>
brandond
pushed a commit
to brandond/rke2
that referenced
this pull request
Jan 14, 2025
* fix-extramount-type (cherry picked from commit 2bc648d) Signed-off-by: Brad Davidson <[email protected]>
brandond
pushed a commit
that referenced
this pull request
Jan 14, 2025
* fix-extramount-type (cherry picked from commit 2bc648d) Signed-off-by: Brad Davidson <[email protected]>
brandond
pushed a commit
that referenced
this pull request
Jan 14, 2025
* fix-extramount-type (cherry picked from commit 2bc648d) Signed-off-by: Brad Davidson <[email protected]>
brandond
pushed a commit
that referenced
this pull request
Jan 14, 2025
* fix-extramount-type (cherry picked from commit 2bc648d) Signed-off-by: Brad Davidson <[email protected]>
brandond
pushed a commit
that referenced
this pull request
Jan 15, 2025
* fix-extramount-type (cherry picked from commit 2bc648d) Signed-off-by: Brad Davidson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
reset the
sourceType
variable for each extra mount entry, ensuring it does not retain the value from a previous mount specification.initialize
sourceType
tov1.HostPathUnset
at the start of processing each mountTypes of Changes
bugfix
Verification
Testing
Mentioned in linked issue
Linked Issues
#7422
User-Facing Change
Further Comments