Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix-extramount-type #7423

Merged
merged 2 commits into from
Jan 10, 2025
Merged

fix-extramount-type #7423

merged 2 commits into from
Jan 10, 2025

Conversation

skanakal
Copy link
Contributor

Proposed Changes

reset the sourceType variable for each extra mount entry, ensuring it does not retain the value from a previous mount specification.
initialize sourceType to v1.HostPathUnset at the start of processing each mount

Types of Changes

bugfix

Verification

Testing

Mentioned in linked issue

Linked Issues

#7422

User-Facing Change


Further Comments

@skanakal skanakal requested a review from a team as a code owner December 12, 2024 17:48
@codecov-commenter
Copy link

codecov-commenter commented Dec 12, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 23.23%. Comparing base (3c629f4) to head (d13cd58).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
pkg/staticpod/staticpod.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7423   +/-   ##
=======================================
  Coverage   23.23%   23.23%           
=======================================
  Files          33       33           
  Lines        3461     3461           
=======================================
  Hits          804      804           
  Misses       2609     2609           
  Partials       48       48           
Flag Coverage Δ
inttests 8.81% <0.00%> (ø)
unittests 16.51% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@brandond brandond merged commit 2bc648d into rancher:master Jan 10, 2025
8 checks passed
brandond pushed a commit to brandond/rke2 that referenced this pull request Jan 13, 2025
* fix-extramount-type

(cherry picked from commit 2bc648d)
Signed-off-by: Brad Davidson <[email protected]>
brandond pushed a commit to brandond/rke2 that referenced this pull request Jan 13, 2025
* fix-extramount-type

(cherry picked from commit 2bc648d)
Signed-off-by: Brad Davidson <[email protected]>
brandond pushed a commit to brandond/rke2 that referenced this pull request Jan 14, 2025
* fix-extramount-type

(cherry picked from commit 2bc648d)
Signed-off-by: Brad Davidson <[email protected]>
brandond pushed a commit to brandond/rke2 that referenced this pull request Jan 14, 2025
* fix-extramount-type

(cherry picked from commit 2bc648d)
Signed-off-by: Brad Davidson <[email protected]>
brandond pushed a commit that referenced this pull request Jan 14, 2025
* fix-extramount-type

(cherry picked from commit 2bc648d)
Signed-off-by: Brad Davidson <[email protected]>
brandond pushed a commit that referenced this pull request Jan 14, 2025
* fix-extramount-type

(cherry picked from commit 2bc648d)
Signed-off-by: Brad Davidson <[email protected]>
brandond pushed a commit that referenced this pull request Jan 14, 2025
* fix-extramount-type

(cherry picked from commit 2bc648d)
Signed-off-by: Brad Davidson <[email protected]>
brandond pushed a commit that referenced this pull request Jan 15, 2025
* fix-extramount-type

(cherry picked from commit 2bc648d)
Signed-off-by: Brad Davidson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants