Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overhaul latest_commit scripts for E2E, more logging and reduce GHA api calls #7427

Merged
merged 2 commits into from
Dec 16, 2024

Conversation

dereknola
Copy link
Member

Proposed Changes

Effectively the same as k3s-io/k3s#11148
Nightly E2E suite is seeing failures due to limits on GH api calls for the "latest commit". This PR attempts to address this in several ways:

  • Allow E2E_RELEASE_VERSION=<commit_SHA> to install a specific commit SHA
  • For the nightly test suite. run the latest_commit.sh script before all the tests, then pass that commit into each test (reduces API calls from I nodes x J tests to a single API call)
  • Allow for an optional authenticated commits request via GH_TOKEN

Types of Changes

E2E, CI

Verification

Testing

Linked Issues

User-Facing Change


Further Comments

@dereknola dereknola requested a review from a team as a code owner December 12, 2024 19:44
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 8.81%. Comparing base (6d26bc0) to head (f567249).
Report is 1 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (6d26bc0) and HEAD (f567249). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (6d26bc0) HEAD (f567249)
unittests 1 0
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #7427       +/-   ##
==========================================
- Coverage   23.23%   8.81%   -14.42%     
==========================================
  Files          33      33               
  Lines        3461    3461               
==========================================
- Hits          804     305      -499     
- Misses       2609    3133      +524     
+ Partials       48      23       -25     
Flag Coverage Δ
inttests 8.81% <ø> (ø)
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dereknola dereknola merged commit ac88bad into rancher:master Dec 16, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants