Validate single branch for tag #7450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Handles case where tagged commit exists on multiple branches - such as when we branch for a new release and then immediately tag an RC. Signed-off-by: Brad Davidson <[email protected]>
briandowns
approved these changes
Dec 23, 2024
cwayne18
approved these changes
Dec 23, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7450 +/- ##
=======================================
Coverage 23.26% 23.26%
=======================================
Files 33 33
Lines 3456 3456
=======================================
Hits 804 804
Misses 2604 2604
Partials 48 48
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Handles case where tagged commit exists on multiple branches - such as when we branch for a new release and then immediately tag an RC.
https://github.com/rancher/rke2/actions/runs/12470754662/job/34806446905#step:5:1512
Types of Changes
bugfix, ci
Verification
See CI
Testing
Linked Issues
User-Facing Change
Further Comments