Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Index arbitrary labels #317

Draft
wants to merge 31 commits into
base: main
Choose a base branch
from
Draft

Index arbitrary labels #317

wants to merge 31 commits into from

Commits on Nov 30, 2024

  1. Add more fields to index when sql-caching is on.

    @ericpromislow
    ericpromislow committed Nov 30, 2024
    Configuration menu
    Copy the full SHA
    e334132 View commit details
    Browse the repository at this point in the history

  2. Restore the gvkKey helper, add event fields. 

    The UI team wasn't sure whether the event fields should go in the empty-string group or in 'events.k8s.io',
so let's go with both until/unless specified otherwise.
    @ericpromislow
    ericpromislow committed Nov 30, 2024
    Configuration menu
    Copy the full SHA
    7b9d611 View commit details
    Browse the repository at this point in the history

  3. More fixes to the fields to index: 

    - Remove the erroneously added management.cattle.io.nodes fields
- Use the builtin Event class, not events.k8s.io (by looking at the dashboard client code)
    @ericpromislow
    ericpromislow committed Nov 30, 2024
    Configuration menu
    Copy the full SHA
    6f0559f View commit details
    Browse the repository at this point in the history

  4. Start on the virtual-field work.

    @ericpromislow
    ericpromislow committed Nov 30, 2024
    Configuration menu
    Copy the full SHA
    de89572 View commit details
    Browse the repository at this point in the history

  5. Map Event.type to Event._type for indexing.

    @ericpromislow
    ericpromislow committed Nov 30, 2024
    Configuration menu
    Copy the full SHA
    95f6362 View commit details
    Browse the repository at this point in the history

  6. Add a unit test for field replacement for Event.type

    @ericpromislow
    ericpromislow committed Nov 30, 2024
    Configuration menu
    Copy the full SHA
    23941cc View commit details
    Browse the repository at this point in the history

  7. Add label processing.

    @ericpromislow
    ericpromislow committed Nov 30, 2024
    Configuration menu
    Copy the full SHA
    d924237 View commit details
    Browse the repository at this point in the history

  8. WIP - moving module imports around

    @ericpromislow
    ericpromislow committed Nov 30, 2024
    Configuration menu
    Copy the full SHA
    f69acb7 View commit details
    Browse the repository at this point in the history

  9. Don't test for transformation of event objects in the common module.

    @ericpromislow
    ericpromislow committed Nov 30, 2024
    Configuration menu
    Copy the full SHA
    6c52f98 View commit details
    Browse the repository at this point in the history

  10. Parse metadata.label queries differently.

    @ericpromislow
    ericpromislow committed Nov 30, 2024
    Configuration menu
    Copy the full SHA
    e255bdc View commit details
    Browse the repository at this point in the history

  11. Improve a variable name that turned out to not be temporary.

    @ericpromislow
    ericpromislow committed Nov 30, 2024
    Configuration menu
    Copy the full SHA
    c3f9e8d View commit details
    Browse the repository at this point in the history

  12. No need to specifically cache certain labels, as all are now cached.

    @ericpromislow
    ericpromislow committed Nov 30, 2024
    Configuration menu
    Copy the full SHA
    97404d6 View commit details
    Browse the repository at this point in the history

  13. Add a test to verify simple label (m.labels.foo=blah) queries work.

    @ericpromislow
    ericpromislow committed Nov 30, 2024
    Configuration menu
    Copy the full SHA
    be5b79f View commit details
    Browse the repository at this point in the history

  14. 'addLabelFields' never returns an error.

    @ericpromislow
    ericpromislow committed Nov 30, 2024
    Configuration menu
    Copy the full SHA
    263752e View commit details
    Browse the repository at this point in the history

  15. Delete superseded function.

    @ericpromislow
    ericpromislow committed Nov 30, 2024
    Configuration menu
    Copy the full SHA
    38acc05 View commit details
    Browse the repository at this point in the history

  16. Was calling 'addLabelFields' one time too many.

    @ericpromislow
    ericpromislow committed Nov 30, 2024
    Configuration menu
    Copy the full SHA
    518fca2 View commit details
    Browse the repository at this point in the history

  17. Start using k8s ParseToRequirements

    @ericpromislow
    ericpromislow committed Nov 30, 2024
    Configuration menu
    Copy the full SHA
    57c36a0 View commit details
    Browse the repository at this point in the history

  18. Pull in the k8s parser.

    @ericpromislow
    ericpromislow committed Nov 30, 2024
    Configuration menu
    Copy the full SHA
    06a2b72 View commit details
    Browse the repository at this point in the history

  19. Successfully test for quotation marks.

    @ericpromislow
    ericpromislow committed Nov 30, 2024
    Configuration menu
    Copy the full SHA
    7d0803f View commit details
    Browse the repository at this point in the history

  20. Add quoted strings to the lexer.

    @ericpromislow
    ericpromislow committed Nov 30, 2024
    Configuration menu
    Copy the full SHA
    1cc78f8 View commit details
    Browse the repository at this point in the history

  21. Move to a forked k8s label lexer to include non-label tests.

    @ericpromislow
    ericpromislow committed Nov 30, 2024
    Configuration menu
    Copy the full SHA
    2638eb5 View commit details
    Browse the repository at this point in the history

  22. Improve and test the way quoted strings in the query are detected.

    @ericpromislow
    ericpromislow committed Nov 30, 2024
    Configuration menu
    Copy the full SHA
    136b636 View commit details
    Browse the repository at this point in the history

  23. Reinstate the original Apache license in the derived code. 

    Following clause 4.3 of the Apache license:
"You must cause any modified files to carry prominent notices stating that You changed the files..."
    @ericpromislow
    ericpromislow committed Nov 30, 2024
    Configuration menu
    Copy the full SHA
    39a6de1 View commit details
    Browse the repository at this point in the history

  24. Ignore case for operators.

    @ericpromislow
    ericpromislow committed Nov 30, 2024
    Configuration menu
    Copy the full SHA
    e51ed0e View commit details
    Browse the repository at this point in the history

  25. Test IN multiple-target-values

    @ericpromislow
    ericpromislow committed Nov 30, 2024
    Configuration menu
    Copy the full SHA
    abf86c5 View commit details
    Browse the repository at this point in the history

  26. Test the not-in operator.

    @ericpromislow
    ericpromislow committed Nov 30, 2024
    Configuration menu
    Copy the full SHA
    3747d7c View commit details
    Browse the repository at this point in the history

  27. Ignore case for operators. 

    SQL is case-insensitive on field names and values, so this just adds consistency.
    @ericpromislow
    ericpromislow committed Nov 30, 2024
    Configuration menu
    Copy the full SHA
    a68e75d View commit details
    Browse the repository at this point in the history

  28. Added tests for parsing EXISTS and NOT-EXISTS queries.

    @ericpromislow
    ericpromislow committed Nov 30, 2024
    Configuration menu
    Copy the full SHA
    1368056 View commit details
    Browse the repository at this point in the history

Commits on Dec 3, 2024

  1. Parse less-than and greater-than ops

    @ericpromislow
    ericpromislow committed Dec 3, 2024
    Configuration menu
    Copy the full SHA
    98418ee View commit details
    Browse the repository at this point in the history

  2. Lasso's CacheFor now takes a watchable argument.

    @ericpromislow
    ericpromislow committed Dec 3, 2024
    Configuration menu
    Copy the full SHA
    2aff54f View commit details
    Browse the repository at this point in the history

  3. Support 'gt' and 'lt' as synonyms for '<' and '>'. 

    I see both types of operators being bandied about -- it's easy to support the aliases.
    @ericpromislow
    ericpromislow committed Dec 3, 2024
    Configuration menu
    Copy the full SHA
    e56460f View commit details
    Browse the repository at this point in the history