Added more fields - part 6.

[ericpromislow]

Related to #48603

[ericpromislow]

I thought there was a problem mapping an array to a single value, but apps.deployments was searchable, as in curl -kgsL 'https://localhost:5111/v1/apps.deployments?filter=spec.template.spec.containers.image=IMAGENAME worked.

I thought apps.daemonsets didn't work, but got confused between apps.daemonsets and apps.daemonset.

Turns out that if we're working on an accessor that ends on an array, like spec.template.spec.containers.image, our code the JS form of spec.template.spec.containers.map(c => c['image']).join("|") .

This means it's vital that the UI does a partial match when trying to match on .....containers.image

[ericpromislow]

From my notes, the accessor for batch.cronjob needs to be spec.jobTemplate.spec.template.spec.containers.image because for whatever reason, s.t.s.c.i is wrapped by that outer spec.jt thing. Who knows why....

[richard-cox]

There's a couple missing

• event
  • involvedObject.uid
• management.cattle.io.projects
  • spec.clusterName

[richard-cox]

I've created rancher/rancher#49116 to address this

[richard-cox]

@ericpromislow @crobby how are we placed getting this in for feature complete?

[ericpromislow]

@ericpromislow @crobby how are we placed getting this in for feature complete?

The PartialEquals operator ~ is supported so the UI should be able to take advantage of this capability. I personally haven't tested any of this with a version of the front-end that can do this, so can't say with full authority, but it should be in the backend.

When I discovered that we map an array of values to X|Y|Z I understood why before I got my hands on this, the UI did partial matches by default (leaving quotes off the target value).

I haven't thought yet about how collapsing an array of.values to a |-separated single string affects sorting. For one thing I'm not sure we can support sorting these collapsed fields.

[richard-cox]

Regarding filtering (both exact and partial) and sorting on items in arrays, that's been spun out to rancher/rancher#49116.

There's a couple of requested fields (not array based) that are missing from the PR though (#485 (review)). If we can get those in we could progress this one

[ericpromislow]

Tom added

	gvkKey("", "v1", "Event"): {
			…
			{"involvedObject", "uid"},
			…
		},

in commit 4477e2 on Jan. 13. That's why it isn't showing up in the changelist.

As for

management.cattle.io.projects

    spec.clusterName

it's in this PR:

$ curl -skL 'https://localhost:5111/v1/management.cattle.io.projects?filter=spec.clusterName=local' | jq .count
2
$ curl -skL 'https://localhost:5111/v1/management.cattle.io.projects?filter=spec.clusterName=flipo' | jq '.data | length'
0

[richard-cox]

Visually looks good. Future worked pulled out to rancher/rancher#49116.

[richard-cox]

@ericpromislow as this one is yet to merge, would there be any objections to adding one more?

provisioning.cattle.io.clusters

• metadata.labels."provisioning.cattle.io/management-cluster-display-name"
• metadata.annotations."provisioning.cattle.io/management-cluster-display-name"

[ericpromislow]

I added it but then realized that we should be pulling in all labels now, and there's no need to add this field.

How do I coax a cluster to have this label to verify I don't need to explicitly add this field?

[richard-cox]

Interesting point, has that part all merged to rancher/rancher? I was getting failure messages on a recent version.

I made a mistake, i'll edit the original comment to avoid confusion, but it's an annotation rather than label.

[ericpromislow]

@richard-cox Can we move further field requests to another issue so we can get this one merged in? Otherwise the scope creep is simple, but it's preventing this from getting into the QA->release part of the pipeline

[richard-cox]

Understood. Created rancher/rancher#49288, also for v2.11.0