Separation between workers and servers for RKE2 clusters - Issue #121 #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glovecchi0
added
documentation
dkeightley
requested changes
Jul 30, 2024
| systemctl enable rke2-agent.service | ||
| systemctl start rke2-agent.service | ||
|
|
||
| cat > /var/lib/rancher/rke2/server/manifests/rke2-ingress-nginx-config.yaml << EOF |
There was a problem hiding this comment.
This is for a server, not needed here?
There was a problem hiding this comment.
@glovecchi0 Can we remove this HelmChartConfig in the worker template?
Comment on lines
+82
to
+86
| # instance_disk_size = var.instance_disk_size | ||
| # disk_type = var.disk_type | ||
| # instance_type = var.instance_type | ||
| # os_image = var.os_image | ||
| # ssh_username = var.ssh_username |
There was a problem hiding this comment.
Do we comment these out in the recipe for any reason? Preferably we'd avoid commented code and rely on safe defaults if we can.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @leodotcloud, @dnoland1, @ajithijk,
This PR is a bit invasive, as it affects the RKE2 distro, which will cascade towards all the modules of the various providers that install RKE2.
The idea is to decouple the Server component from the Worker component, as done for K3s.
Resolves: #121