Review of AWS modules and subsequent correction of RKE/RKE2/K3S recipes #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glovecchi0
added
documentation
|
Rewrote AWS EC2 x RKE (split-role) recipe. The documentation has also been revised. tfvars example: prefix = "glovecchio"
aws_region = "eu-west-1"
master_nodes_count = 1
worker_nodes_count = 1
ssh_username = "ubuntu"
rancher_hostname = "glovecchio"
rancher_password = "Mypassword.1234" |
|
Rewrote AWS EC2 x RKE2 recipe. The documentation has also been revised. tfvars example: prefix = "glovecchio"
aws_region = "eu-west-1"
instance_count = 2
ssh_username = "ubuntu"
rancher_hostname = "glovecchio"
rancher_password = "Mypassword.1234" |
|
I will fix conflicts at the end of the review. |
|
Added Rancher deployment to the AWS EC2 x RKE (split-role) recipe. tfvars example: prefix = "glovecchio"
aws_region = "eu-west-1"
server_nodes_count = 1
worker_nodes_count = 1
ssh_username = "ubuntu"
rancher_hostname = "glovecchio"
rancher_password = "Mypassword.1234" |
|
Rewrote AWS EC2 x K3S recipe. The documentation has also been revised. tfvars example: prefix = "glovecchio"
aws_region = "eu-west-1"
server_nodes_count = 1
worker_nodes_count = 1
ssh_username = "ubuntu"
rancher_hostname = "glovecchio"
rancher_password = "Mypassword.1234" |
leodotcloud
suggested changes
Jul 12, 2024
recipes/upstream/aws/k3s/README.md
Outdated
|
|
||
| ```bash | ||
| AWS_PROFILE=<profile name> terraform plan -var-file terraform.tfvars | ||
| AWS_PROFILE=<profile name> terraform apply -var-file terraform.tfvars | ||
| terraform init -upgrade ; terraform apply -target=module.k3s-first-server.tls_private_key.ssh_private_key -target=module.k3s-first-server.local_file.private_key_pem -target=module.k3s-first-server.local_file.public_key_pem -target=module.k3s-first-server.aws_key_pair.key_pair -target=module.k3s-first-server.aws_vpc.vpc -target=module.k3s-first-server.aws_subnet.subnet -target=module.k3s-first-server.aws_security_group.sg_allowall -auto-approve ; terraform apply -auto-approve |
There was a problem hiding this comment.
Let's explore if there is a way to avoid such a long terraform apply.
There was a problem hiding this comment.
@leodotcloud, fixed as requested; now everything works with a single command.
|
@glovecchi0 can you take care of the conflicts? |
Yes; I'll work on It. |
leodotcloud
approved these changes
Jul 26, 2024
…r-up into fix/review-aws-modules
Reviewed tests for AWS EC2 and AWS EC2 x RKE x Rancher Rebase Reviewed tests for AWS EC2 and AWS EC2 x RKE2 x Rancher Fixed code in path recipes/rke/split-roles/aws - Added Rancher deployment Fixed AWS x RKE2 instances count Rewrote AWS EC2 x K3S recipe Reviewed tests for AWS EC2 x RKE (split-roles) Fixed AWS x K3S README.md file Fixed AWS x K3S README.md file Fixed copy/paste issue Rebase Fixed all the AWS recipes Fixed RKE split-roles recipe One-destroy command - GKE x RKE,RKE2,K3s Reviewed tests for AWS EC2 and AWS EC2 x RKE x Rancher Fixed AWS x RKE2 instances count Reviewed tests for AWS EC2 x RKE (split-roles) Fixed AWS x K3S README.md file Fixed copy/paste issue Fixed RKE split-roles recipe Revised standalone RKE module for AWS Fixed recipes/standalone/aws/rke/README.md file
…r-up into fix/review-aws-modules
This was referenced Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewed AWS modules and rewrote AWS EC2 x RKE recipe.
No features have been modified or added, but only some issues have been resolved, including: #99 , #118 , #119 , and #120 .
The documentation has also been revised.
tfvars example: