Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix module rke2_first_server instance_security_group var typo #156

Merged
merged 1 commit into from
Jul 30, 2024
Merged

fix module rke2_first_server instance_security_group var typo #156

merged 1 commit into from
Jul 30, 2024

Conversation

donnyyu
Copy link
Contributor

@donnyyu donnyyu commented Jul 30, 2024

The upstream aws rke2 module instance_security_group was using ssh_key_pair_name variable

dkeightley
dkeightley approved these changes Jul 30, 2024
View reviewed changes
Copy link
Contributor

@dkeightley dkeightley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, we may have other PRs making this change but good to get this in as it's quick to review

@dkeightley dkeightley merged commit a6af686 into main Jul 30, 2024
4 checks passed
@dkeightley dkeightley deleted the fix/recipes-upstream-aws-rke2 branch July 30, 2024 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkeightley dkeightley dkeightley approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@donnyyu @dkeightley