Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AWS] Default to allow 80/http for convenience #171

Merged
merged 30 commits into from
Feb 10, 2025
Merged

[AWS] Default to allow 80/http for convenience #171

merged 30 commits into from
Feb 10, 2025

Conversation

dkeightley
Copy link
Contributor

This will redirect to https for the Rancher ingress, and allow testing with non-TLS ingress objects without having to manually add to the SG or experience connection timeouts.

@dkeightley dkeightley requested a review from glovecchi0 February 5, 2025 03:18
@glovecchi0
Copy link

Hi @dkeightley,
I don't know if anything has changed since this last PR, but I'm getting the same error I got here: #174 (comment)

image image

By changing the default value of the create_ssh_key_pair variable, the code starts and stops only due to the problem of the default VPC and Subnet, which are not present using my account.

image image

What do I have to do to unlock this thing?
Might it be worth creating a new VPC by default if there isn't one defined?

Using the team account instead, with the modification of the create_ssh_key_pair variable everything works as expected.

image

Copy link

@glovecchi0 glovecchi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Take a look at #171 (comment)

@glovecchi0 glovecchi0 self-requested a review February 7, 2025 08:13
Copy link

@glovecchi0 glovecchi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After realigning the main branch with the PR, using the team account, I get the following result:

image image image image

The deployment worked and the SG rule was applied correctly.

@dkeightley dkeightley merged commit 884d8b7 into main Feb 10, 2025
3 checks passed
@dkeightley dkeightley deleted the allow-http branch February 10, 2025 00:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants